Skip to content

Enable MALI Greenland mesh overlap with ocean mesh, through a buffer defined by a geojson file#876

Open
andrewdnolan wants to merge 1 commit intoMPAS-Dev:mainfrom
andrewdnolan:moderate_refinement
Open

Enable MALI Greenland mesh overlap with ocean mesh, through a buffer defined by a geojson file#876
andrewdnolan wants to merge 1 commit intoMPAS-Dev:mainfrom
andrewdnolan:moderate_refinement

Conversation

@andrewdnolan
Copy link
Collaborator

@andrewdnolan andrewdnolan commented Dec 19, 2024

This pull request adds a geojson file for 45 km buffer off of the coast of Greenland. This is then used by the Greenland mesh generation testcase.

No major code changes, just adding an input file.

@andrewdnolan andrewdnolan added land ice in progress This PR is not ready for review or merging labels Dec 19, 2024
@andrewdnolan andrewdnolan removed the in progress This PR is not ready for review or merging label Feb 27, 2026
@andrewdnolan andrewdnolan marked this pull request as ready for review February 27, 2026 15:02
gridded_dataset=source_gridded_dataset_1km,
projection=src_proj, geojson_file=None)
gridded_dataset=source_gridded_dataset_1km, projection=src_proj,
geojson_file="greenland_only_outline_45km_buffer_latlon_singlepart.geojson", # noqa: E501
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trhille , will this line make this new geojson buffer the new behavior? Is that what we want?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that will make it cull to the geojson file if you set cull_distance < 0 in the .cfg file. If cull_distance > 0, it will cull both to the geojson file and to the uniform distance from the ice margin.
We could set geojson_file in the .cfg file instead of hard-coding it here, for some extra control.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To answer your second question, I think we want this to be the new default behavior, but that could still be introduced through the default .cfg file instead of hardcoded in the script.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A config option seem like the right call. We can have it on by default if, but also the option turn it off and/or use a different buffer geojson file.

@trhille
Copy link
Collaborator

trhille commented Feb 27, 2026

Testing

I successfully created a 4–40km mesh with these changes:
image

However, I notice that the geojson file seems to extend beyond our bed topography data set in a few places and we get artifacts with bedTopography = 0 at the edge of the mesh:
Screenshot 2026-02-27 at 1 37 00 PM

I'm not sure what's the best way of dealing with this. We could manually edit the geojson to stay within the bounds of the gridded dataset. Or we could set a mask that is the intersection of the two. It's unlikely to ever actually interact with ice, but it's definitely not a desirable feature.

@andrewdnolan andrewdnolan changed the title Enable coarse mesh resolution over the open ocean by using geojson file. Enable MALI Greenland mesh overlap with ocean mesh, through a buffer defined by a geojson file Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants