Enable MALI Greenland mesh overlap with ocean mesh, through a buffer defined by a geojson file#876
Enable MALI Greenland mesh overlap with ocean mesh, through a buffer defined by a geojson file#876andrewdnolan wants to merge 1 commit intoMPAS-Dev:mainfrom
Conversation
a632621 to
589e70e
Compare
| gridded_dataset=source_gridded_dataset_1km, | ||
| projection=src_proj, geojson_file=None) | ||
| gridded_dataset=source_gridded_dataset_1km, projection=src_proj, | ||
| geojson_file="greenland_only_outline_45km_buffer_latlon_singlepart.geojson", # noqa: E501 |
There was a problem hiding this comment.
@trhille , will this line make this new geojson buffer the new behavior? Is that what we want?
There was a problem hiding this comment.
Yes, that will make it cull to the geojson file if you set cull_distance < 0 in the .cfg file. If cull_distance > 0, it will cull both to the geojson file and to the uniform distance from the ice margin.
We could set geojson_file in the .cfg file instead of hard-coding it here, for some extra control.
There was a problem hiding this comment.
To answer your second question, I think we want this to be the new default behavior, but that could still be introduced through the default .cfg file instead of hardcoded in the script.
There was a problem hiding this comment.
A config option seem like the right call. We can have it on by default if, but also the option turn it off and/or use a different buffer geojson file.


This pull request adds a geojson file for 45 km buffer off of the coast of Greenland. This is then used by the Greenland mesh generation testcase.
No major code changes, just adding an input file.