Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 6, 2025

Module repository listings displayed "1 stycznia 1970" (Jan 1, 1970) or the oldest version's timestamp instead of the latest version's update date.

Changes

  • OnlineState.kt: Changed versions.lastOrNull() to versions.firstOrNull() when retrieving module timestamp

The versions list is ordered newest-first. Using lastOrNull() incorrectly retrieved the oldest version's timestamp.

  return OnlineState(
      installed = installed,
      updatable = updatable,
      hasLicense = license.orEmpty().isNotBlank(),
-     lastUpdated = versions.lastOrNull()?.timestamp ?: 0f,
+     lastUpdated = versions.firstOrNull()?.timestamp ?: 0f,
  )

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED -Xmx2048m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Modules date in repo is wrong again</issue_title>
<issue_description>### Checklist

  • No one has submitted a similar or identical bug report before
  • I'm using the latest version of MMRL

Bug description

Image

Expected behavior

Modules in repositories should have correct date

Actual behavior

Wrong date

Steps to reproduce

  1. Open Repo > Modules
  2. Enable show update time

UI / OS

crDroid

Android Version

16

Additional info

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

@juliazero Fixed in build 34195 🎉 @juliazero But still wrong. Displayed date is from first module version

@DerGoogler </comment_new>

  • Fixes MMRLApp/MMRL#547

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Changed OnlineState.lastUpdated to use firstOrNull() instead of lastOrNull()
to get the timestamp from the newest version in the versions list, not the oldest.

Co-authored-by: DerGoogler <54764558+DerGoogler@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix wrong modules date in repository Fix module update date showing oldest version instead of latest Dec 6, 2025
Copilot AI requested a review from DerGoogler December 6, 2025 20:48
@DerGoogler DerGoogler marked this pull request as ready for review December 14, 2025 16:51
@DerGoogler DerGoogler merged commit 6369f42 into master Dec 14, 2025
5 checks passed
@DerGoogler DerGoogler deleted the copilot/fix-modules-date-repo branch December 14, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Modules date in repo is wrong again

2 participants