Replace static success message with setup verification query#1
Open
krisajenkins wants to merge 1 commit intoMLH:mainfrom
Open
Replace static success message with setup verification query#1krisajenkins wants to merge 1 commit intoMLH:mainfrom
krisajenkins wants to merge 1 commit intoMLH:mainfrom
Conversation
Users frequently paste the setup script and click 'Run' instead of 'Run All', which only executes the final statement. The old static success message gave no indication that the setup was incomplete. The new final query checks that: - Current database is set to RAW_DB - CUSTOMERS table exists and has data - PRODUCTS table exists and has data - ORDERS table exists and has data If all checks pass, it reports '✓ 4/4 checks passed. Setup successful!' Otherwise, it shows how many checks failed and reminds the user to click 'Run All' to execute the entire script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users frequently paste the setup script into the Snowflake UI and click "Run" instead of "Run All". This causes only the final statement to execute, which was previously a static success message:
This gave users a false sense of success even though none of the actual setup (warehouse, databases, tables, functions) had been created.
Solution
Replace the static message with a verification query that checks whether the setup actually completed:
RAW_DBCUSTOMERStable exists and has dataPRODUCTStable exists and has dataORDERStable exists and has dataThe query now reports:
✓ 4/4 checks passed. Setup successful!when everything is properly configured✗ X/4 checks passed. Setup incomplete - please click "Run All" to execute the entire script.when setup is incompleteTest Plan