Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
objects/ruleset-metadata/definition.jsonnamedruleset-metadatathat maps fields from the provided SQL-style metadata into MISP attributes (e.g.,title,uuid,original-uuid,format,author,creation-date,last-modif,github-path,cve-id,vote-up,vote-down,is-favorited).uuid,original-uuid,source,github-path,user-id,editor) and descriptive/versioning fields (title,description,format,license,version,to-string).titleanduuidas core fields and set appropriate MISP attribute types and UI priorities for each attribute.Testing
./validate_all.sh; the run produced environment warnings about a missinguuidparsebinary but did not report object-specific schema errors for the newruleset-metadatatemplate before tool output was truncated.objects/ruleset-metadata/definition.jsonwas checked by the repository validation pass that iterates over all object templates with no schema failures observed for this template.Codex Task