x509: add missing certificate fields from issue #88#508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
x509object was missing fields commonly produced by certificate parsers (e.g., certigo) and lacked RFC 5280–style breakdowns forsubjectandissuercomponents, limiting automated ingestion and correlation.Description
issuer-*andsubject-*attributes (common name, country, organization, organizational unit, DN qualifier, state/province, serial number, locality, title, surname, given name, initials, pseudonym, generation qualifier, key id) to thex509object definition.key_usage,extended_key_usage,ocsp_server, andissuing_certificateand anis_self_signedboolean alias forself_signedto improve compatibility with certigo output.formati→format) and bump thex509object templateversionfrom13to14.Testing
jq empty objects/x509/definition.jsonto verify the JSON is valid and it succeeded../jq_all_the_things.shto reformat and normalize object files and it completed (exit code 0) prior to creating the PR metadata../validate_all.shwhich exited with the repository’s guard error instructing to run./jq_all_the_things.shwhen local diffs exist, confirming there are no schema errors introduced by this change.Codex Task