Skip to content

Debug airfoil sign error #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danieljvickers wants to merge 7 commits into
base: master
Choose a base branch
from
+97 −92
Open

Debug airfoil sign error #1443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05fbe8f
one-line change that should fix stbility issues in periodicity for mo…
danieljvickers May 6, 2026
cda6e68
Fixed sign error
danieljvickers May 16, 2026
6838efd
Removing accidental additino
danieljvickers May 16, 2026
418efe8
Merge branch 'master' into debug-airfoil-sign-error
danieljvickers May 16, 2026
1fa8b01
Merge branch 'master' into debug-airfoil-sign-error
danieljvickers May 26, 2026
95b083b
Fixed additional 2D cases
danieljvickers May 26, 2026
d8faa14
Updated airfoil golden files:
danieljvickers May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/simulation/m_compute_levelset.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ contains
if (xy_local(2) >= 0._wp) then
! finds the location on the airfoil grid with the minimum distance (closest)
do k = 1, Np
dist_vec(1) = xy_local(1) - airfoil_grid_u(k)%x
dist_vec(2) = xy_local(2) - airfoil_grid_u(k)%y
dist_vec(1) = airfoil_grid_u(k)%x - xy_local(1)
dist_vec(2) = airfoil_grid_u(k)%y - xy_local(2)
dist_vec(3) = 0._wp
dist = sqrt(sum(dist_vec**2))
if (k == 1) then
Expand All @@ -146,14 +146,14 @@ contains
end if
end if
end do
dist_vec(1) = xy_local(1) - airfoil_grid_u(global_id)%x
dist_vec(2) = xy_local(2) - airfoil_grid_u(global_id)%y
dist_vec(1) = airfoil_grid_u(global_id)%x - xy_local(1)
dist_vec(2) = airfoil_grid_u(global_id)%y - xy_local(2)
dist_vec(3) = 0
dist = global_dist
else
do k = 1, Np
dist_vec(1) = xy_local(1) - airfoil_grid_l(k)%x
dist_vec(2) = xy_local(2) - airfoil_grid_l(k)%y
dist_vec(1) = airfoil_grid_l(k)%x - xy_local(1)
dist_vec(2) = airfoil_grid_l(k)%y - xy_local(2)
dist_vec(3) = 0
dist = sqrt(sum(dist_vec**2))
if (k == 1) then
Expand All @@ -166,9 +166,9 @@ contains
end if
end if
end do
dist_vec(1) = xy_local(1) - airfoil_grid_l(global_id)%x
dist_vec(2) = xy_local(2) - airfoil_grid_l(global_id)%y
dist_vec(3) = 0
dist_vec(1) = airfoil_grid_l(global_id)%x - xy_local(1)
dist_vec(2) = airfoil_grid_l(global_id)%y - xy_local(2)
dist_vec(3) = 0._wp
dist = global_dist
end if

Expand Down Expand Up @@ -230,14 +230,14 @@ contains
end if
end if
end do
dist_vec(1) = xyz_local(1) - airfoil_grid_u(global_id)%x
dist_vec(2) = xyz_local(2) - airfoil_grid_u(global_id)%y
dist_vec(1) = airfoil_grid_u(global_id)%x - xyz_local(1)
dist_vec(2) = airfoil_grid_u(global_id)%y - xyz_local(2)
dist_vec(3) = 0._wp
dist_surf = global_dist
else
do k = 1, Np
dist_vec(1) = xyz_local(1) - airfoil_grid_l(k)%x
dist_vec(2) = xyz_local(2) - airfoil_grid_l(k)%y
dist_vec(1) = airfoil_grid_l(k)%x - xyz_local(1)
dist_vec(2) = airfoil_grid_l(k)%y - xyz_local(2)
dist_vec(3) = 0
dist_surf = sqrt(sum(dist_vec**2))
if (k == 1) then
Expand All @@ -250,8 +250,8 @@ contains
end if
end if
end do
dist_vec(1) = xyz_local(1) - airfoil_grid_l(global_id)%x
dist_vec(2) = xyz_local(2) - airfoil_grid_l(global_id)%y
dist_vec(1) = airfoil_grid_l(global_id)%x - xyz_local(1)
dist_vec(2) = airfoil_grid_l(global_id)%y - xyz_local(2)
dist_vec(3) = 0._wp
dist_surf = global_dist
end if
Expand Down
147 changes: 76 additions & 71 deletions tests/0B07F3A1/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading