Skip to content

homebrew: fix toolchain install without git metadata #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 5 commits into from
Dec 19, 2025
Merged

homebrew: fix toolchain install without git metadata #1096

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45090f5
homebrew: fix toolchain install without git metadata
sbryngelson Dec 19, 2025
5b18ea1
homebrew: scope pretend-version vars + update cantera to >=3.1.0
sbryngelson Dec 19, 2025
7778507
homebrew: add SETUPTOOLS_SCM_PRETEND_VERSION fallback for hatch-vcs
sbryngelson Dec 19, 2025
5438ad8
homebrew: fix rubocop style warning (use ENV.fetch)
sbryngelson Dec 19, 2025
8c8a522
homebrew: fix hash alignment for rubocop
sbryngelson Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions packaging/homebrew/mfc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,43 @@ def install
# Create Python virtual environment inside libexec (inside Cellar for proper bottling)
venv = libexec/"venv"
system Formula["python@3.12"].opt_bin/"python3.12", "-m", "venv", venv
system venv/"bin/pip", "install", "--upgrade", "pip", "setuptools", "wheel"
system venv/"bin/pip", "install", "--upgrade", "pip", "setuptools", "wheel", "setuptools-scm"

# Install Cantera from PyPI using pre-built wheel (complex package, doesn't need custom flags)
# Cantera has CMake compatibility issues when building from source with newer CMake versions
system venv/"bin/pip", "install", "cantera==3.1.0"
# Match the version constraint from toolchain/pyproject.toml
system venv/"bin/pip", "install", "--only-binary=:all:", "cantera>=3.1.0"

# Install MFC Python package and dependencies into venv
# Use editable install (-e) to avoid RECORD file issues when venv is symlinked at runtime
# Dependencies will use pre-built wheels from PyPI
# Keep toolchain in buildpath for now - mfc.sh needs it there
system venv/"bin/pip", "install", "-e", buildpath/"toolchain"
#
# MFC's toolchain uses VCS-derived versioning (via Hatch/hatch-vcs) and Homebrew builds from
# GitHub release tarballs without a .git directory. Scope pretend-version env vars tightly
# to avoid polluting subsequent pip installs.
pretend_env = {
"SETUPTOOLS_SCM_PRETEND_VERSION_FOR_MFC" => version.to_s,
"SETUPTOOLS_SCM_PRETEND_VERSION_FOR_mfc" => version.to_s,
"SETUPTOOLS_SCM_PRETEND_VERSION" => version.to_s, # Fallback for hatch-vcs/setuptools-scm
}
saved_env = {}
pretend_env.each do |k, v|
saved_env[k] = ENV.fetch(k, nil)
ENV[k] = v
end

begin
system venv/"bin/pip", "install", "-e", buildpath/"toolchain"
ensure
pretend_env.each_key do |k|
if saved_env[k].nil?
ENV.delete(k)
else
ENV[k] = saved_env[k]
end
end
end

# Create symlink so mfc.sh uses our pre-installed venv
mkdir_p "build"
Expand Down
Loading