Skip to content

[rails] Mark async-db calls as IO bound #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
p8 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[rails] Mark async-db calls as IO bound #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frameworks/rails/app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ def self.redis
end

def self.pool_size
ENV.fetch('RAILS_MAX_THREADS', 4).to_i
ENV.fetch('RAILS_MAX_THREADS', 4).to_i + ENV.fetch("MAX_IO_THREADS", 10).to_i
end
end
4 changes: 3 additions & 1 deletion frameworks/rails/config/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@ def call(env)

# Threads marked as IO bound are allowed to go over Puma's max thread limit.
class MarkAsIOBoundThreads
IOBoundPaths = %w[/baseline11 /baseline2 /async-db].map { [_1, nil] }.to_h.freeze

def initialize(app)
@app = app
end

def call(env)
if env['PATH_INFO'].start_with?('/baseline')
if IOBoundPaths.has_key? env['PATH_INFO']
env["puma.mark_as_io_bound"].call
end
@app.call(env)
Expand Down