Use a group per PR so benchmark requests do not interfer with each other#800
Open
Kaliumhexacyanoferrat wants to merge 1 commit into
Open
Use a group per PR so benchmark requests do not interfer with each other#800Kaliumhexacyanoferrat wants to merge 1 commit into
Kaliumhexacyanoferrat wants to merge 1 commit into
Conversation
Kaliumhexacyanoferrat
added
the
platform
Collaborator
Author
|
Current case: 
Requesting 913 cancelled 912 while 911 was still waiting. So pending (waiting) requests are definitively cancelled by newer ones. |
Owner
|
Hmm there is an issue with this but I don't know yet the true case, need to investigate further but I agree this cancellation happens, however it doesn't always happen so it is a bit smelly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, benchmark requests (workflow
Benchmark PR) are globally synchronized, which means that GitHub will cancel pending ones as soon as a new one arrives. Contributors are not notified about this, so they will just wonder when the benchmark results will arrive.As the custom runner is limited to one concurrent job anyway (I guess?), we can attribute the benchmark requests to a PR, so each PR will have it's own queue. Triggering multiple benchmark requests from the same PR will then cancel the older requests which is desired behavior.
Cannot test this locally, but this should be quite straight forward.
@MDA2AV can you affirm the limit of one concurrent job on the runner?