Skip to content

ComfyUI: Remove --normalvram#1644

Open
NeuralFault wants to merge 2 commits into
LykosAI:mainfrom
NeuralFault:remove-normalvram
Open

ComfyUI: Remove --normalvram#1644
NeuralFault wants to merge 2 commits into
LykosAI:mainfrom
NeuralFault:remove-normalvram

Conversation

@NeuralFault
Copy link
Copy Markdown
Contributor

@NeuralFault NeuralFault commented May 17, 2026

--normalvram has been removed from ComfyUI as of this PR and will throw unknown argument error at package launch if the user has it enabled in Launch Options window as it appears there.

It's function is implied by default by ComfyUI unless it is overridden by the user or by certain hardware checks by Comfy's internal logic.

Since SM sets normalvram automatically on installs with 4-8GB vram GPUs, any user before this change that has their comfy install using the repo commits instead of releases, their comfy launch will hit a launch argument error.

Removed 'normalvram' option
@NeuralFault NeuralFault marked this pull request as ready for review May 17, 2026 10:03
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the --normalvram argument from ComfyUI's configuration options and initial value selection logic. Feedback identifies a critical backward compatibility issue: removing the option from the UI does not clear it from existing user configurations, which will cause ComfyUI to crash upon encountering the now-unknown argument. It is recommended to filter this flag out during the package execution process. Additionally, the GPU detection logic is susceptible to an InvalidOperationException if no GPUs are found, which should be mitigated by providing a default value before calling Max().

Comment thread StabilityMatrix.Core/Models/Packages/ComfyUI.cs
Comment thread StabilityMatrix.Core/Models/Packages/ComfyUI.cs
@NeuralFault NeuralFault marked this pull request as draft May 17, 2026 10:16
@NeuralFault
Copy link
Copy Markdown
Contributor Author

Added stripping of existing --normalvram argument from settings.json upon settings load and atomic rebuild.

Launch argument removed from comfy configuration and covers users with pre-existing set arg from either manually set, or when SM set it automatically for 4-8GB GPU during install.

@NeuralFault NeuralFault marked this pull request as ready for review May 18, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant