Skip to content

Solution to #4146 : Adding the option to specify the Microsoft Tenant…#4151

Open
agademer wants to merge 1 commit intoLycheeOrg:masterfrom
agademer:agademer/improvement_microsoft_tenant_id
Open

Solution to #4146 : Adding the option to specify the Microsoft Tenant…#4151
agademer wants to merge 1 commit intoLycheeOrg:masterfrom
agademer:agademer/improvement_microsoft_tenant_id

Conversation

@agademer
Copy link

@agademer agademer commented Mar 6, 2026

… ID during Azure Authentication via Socialite

Answer to #4146

The source of the solution is given in the discussion.

Tested on a docker fresh install (hot fix of the php file as I don't have a build environment to test)

Again, thanks for the great app !

Antoine

…ft Tenant ID during Azure Authentication via Socialite
@agademer agademer requested a review from a team as a code owner March 6, 2026 10:40
@ildyria ildyria enabled auto-merge (squash) March 6, 2026 13:52
@agademer
Copy link
Author

agademer commented Mar 6, 2026

@ildyria : I have the impression that the Php style checker want a space after the comma.
'tenant' => env('MICROSOFT_TENANT_ID', 'common'), and not
'tenant' => env('MICROSOFT_TENANT_ID','common'),

I have no idead how to correct that now that the PR is started (I'm somehow new to this PR process).
But I'm eager to learn / help.

Kind regards,
Antoine

@ildyria
Copy link
Member

ildyria commented Mar 6, 2026

I have no idead how to correct that now that the PR is started (I'm somehow new to this PR process).

Super easy. Add the missing space, make a commit on the same branch and push on your side. It will automatically pick it up and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants