Feature - Packet Enrichment Improvements #248
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description:
This PR adds new options to Apollo's Packet Enrichment module to allow finer control over which packets are sent and which events are fired. Additionally, it introduces a new event:
ApolloPlayerUseItemBucketEvent- fired when a player uses a bucket (1.7 & 1.8).This is to prevent water and lava bucket desync. A reference open-source plugin demonstrating practical usage is available here: apollo-bucket-desync-fix.
Added new options:
PLAYER_ATTACK_PACKETBooleanfalsePLAYER_ATTACK_EVENTApolloPlayerAttackEventwhen the packet is received.BooleanfalsePLAYER_CHAT_OPEN_PACKETBooleanfalsePLAYER_CHAT_OPEN_EVENTApolloPlayerChatOpenEventwhen the packet is received.BooleanfalsePLAYER_CHAT_CLOSE_PACKETBooleanfalsePLAYER_CHAT_CLOSE_EVENTApolloPlayerChatCloseEventwhen the packet is received.BooleanfalsePLAYER_USE_ITEM_PACKETBooleanfalsePLAYER_USE_ITEM_EVENTApolloPlayerUseItemEventwhen the packet is received.BooleanfalsePLAYER_USE_ITEM_BUCKET_PACKETBooleanfalsePLAYER_USE_ITEM_BUCKET_EVENTApolloPlayerUseItemBucketEventwhen the packet is received.BooleanfalseReview Request Checklist
feature/add-options).