Add a reusable action for setting up the project for GitHub workflows. #892
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @davereid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new, reusable GitHub composite action designed to streamline and standardize the setup of development environments for projects that utilize the Drainpipe framework within GitHub Actions workflows. The primary goal is to provide a consistent and efficient build environment by automating the initialization of a Drupal project, configuring DDEV, and setting up Composer with specific Drainpipe dependencies, thereby enhancing CI/CD capabilities.
Highlights
- New GitHub Composite Action: Introduced a new reusable GitHub composite action located at
.github/actions/setup-build/action.yml. This action standardizes the setup process for projects within GitHub Actions workflows. - Automated Project Setup: The action automates the creation of a Drupal project using Composer, checking out the
drainpiperepository, and configuring the environment with DDEV. - DDEV and Composer Integration: It includes steps to install and configure DDEV (allowing for custom PHP and NodeJS versions), and extensively configures Composer to work with
lullabot/drainpipeandlullabot/drainpipe-devpackages, including setting up path repositories and modifyingcomposer.jsonfor autoloading. - Configurable Inputs: The action provides several inputs (
composer-project,php-version,nodejs-version,ddev-start) to allow for customization of the build environment, making it flexible for various project needs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a new GitHub action to set up a build environment for Drainpipe projects. The action handles PHP, NodeJS, and DDEV configuration. I've identified a potential issue with the DDEV start condition and suggested a refactoring for the composer configuration step to improve maintainability.
| composer config repositories.drainpipe-dev --json '{"type": "path", "url": "drainpipe/drainpipe-dev", "options": {"symlink": true}}' | ||
| composer config minimum-stability dev | ||
| composer config platform.php ${{ inputs.php-version || '8.3' }} | ||
| php -r '$json = json_decode(file_get_contents ("composer.json"), true);$json["autoload-dev"]["files"][] = "vendor/lullabot/drainpipe/scaffold/env/dotenv.php";file_put_contents("composer.json", json_encode($json, JSON_UNESCAPED_SLASHES|JSON_PRETTY_PRINT));' |
There was a problem hiding this comment.
This command injects PHP code directly into the composer.json file using php -r. While functional, this approach is not ideal for maintainability and readability. Consider using composer's built-in functionality for managing autoloading, or refactor this into a separate script for better organization.
|
@davereid is this something you want to continue on, or document so someone else could pick it up? |
No description provided.