Fixing bug around order of open generic registration#4607
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in AutoMapper 14.0.0 where the order of open generic type map registration could cause a NullReferenceException. The bug occurred when a derived map with an IncludeBase reference to a closed generic type (e.g., SourceBase<FooBar>) was registered before its open generic base map (e.g., SourceBase<>).
Changes:
- Fixed ProfileMap.Configure to use FindTypeMapFor instead of TypeMapConfiguration.TypeMap property
- Added comprehensive tests to verify both registration orderings work correctly
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/AutoMapper/ProfileMap.cs | Fixed bug where TypeMapConfiguration.TypeMap could point to wrong TypeMap when closed generics are created from open generic definitions |
| src/UnitTests/Bug/OpenGenericInheritanceOrder.cs | Added regression tests for both map registration orderings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jbogard
deleted the
4567-automapper-1400-breaks-the-order-of-created-maps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4567