Add manual rotation config option for portrait panels where KMS reports native resolution.#4877
Open
sam1am wants to merge 2 commits intoLizardByte:masterfrom
Open
Add manual rotation config option for portrait panels where KMS reports native resolution.#4877sam1am wants to merge 2 commits intoLizardByte:masterfrom
sam1am wants to merge 2 commits intoLizardByte:masterfrom
Conversation
Adds a manual_rotation config option (0, 90, 180, 270 degrees) for portrait panels used in landscape orientation (e.g. Steam Deck) where KMS reports raw panel resolution instead of logical orientation.
- Locale JSON keys sorted alphabetically - Web UShader duplication documented - Created tests/unit/test_config.cpp with parameterized tests covering: - All valid rotation values (0, 90, 180, 270) - Invalid values that should normalize to 0 (45, 360, -90, 1, non-numeric "abc") - Default value verification
2 tasks
|
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Can we auto detect the rotation? I ask because if the user has multiple monitors and switches between which ones are streamed, this solution is likely to be painful.
Contributor
|
Oh hey this shader was one of the things I wanted to investigate for #4788 since the protocol can send a wonky framebuffer with transform as metadata. So yeah this setting could use some more options, i.e. even 0deg should be explicitly set, not the default, and the default should be auto, i.e. let the platform decide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a manual_rotation config option (0, 90, 180, 270 degrees) for portrait panels used in landscape orientation (e.g. Steam Deck, GPD, etc.) where KMS reports raw panel resolution instead of logical orientation.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage