Add implementation for showing poll results, make unpin action actionId-aware #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
TODO: Figure out how to get the End Poll button to work so that streamers can actually end their polls without disabling Hyperchat... TODO: Show Poll ending message in chat (screenshot of YT's impl below) when poll ends, via EngagementMessageRenderer |
KentoNishi
requested changes
Feb 25, 2025
Member
|
hmm. so this is targeted at main (mv3), but it needs to be targeted to mv2 instead since livetl still imports the mv2 version. |
…Id-aware so that multiple things can be removed (e.g. polls) instead of only pinned messages
… the choice is multiline
Contributor
Author
|
Tried creating the poll with text as wide as possible: |
Merged
KentoNishi
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #110
Uses gray as the ProgressLinear color so that the white bar background shows up (tried all other options, it either made it completely invisible or had no background).
The actionId changes are so that multiple things can be removed via the removal message (e.g. polls) instead of only pinned messages.
Actual voting panel isn't implemented because it SEEMS like it just works with Hyperchat enabled already; no need to try to replace it.