feat(infobox): do not query for matchticker on finished events in infobox league #6958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbergen
reviewed
Jan 11, 2026
| -- assume an event is finished 2 days after the enddate latest | ||
| -- 1 day for finishing the day of the enddate | ||
| -- 1 day for potential timezone offsets plus events reaching into the next day from time to time (i.e. over midnight) | ||
| return endDate + DateExt.daysToSeconds(2) < DateExt.getCurrentTimestamp() |
Collaborator
There was a problem hiding this comment.
Me might as well add the second day into the phase calculation in Module:Tournament, and just use the phase here
Nevermind, the phase is used e.g. on mainpage matchticker and should be rather tight
Collaborator
There was a problem hiding this comment.
and the entire point of this change is to avoid the query the calc of phase comes after the query...
Think you are confusing match and tournament phase, i was talking about the latter, which could be used from https://github.com/Liquipedia/Lua-Modules/pull/6958/changes#diff-c785af01ddd309e4adb29a541146f4098cb8d84d697b7e051cbc9415c1458427R305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #6946
Summary
avaoid the query for finished events for perf reasons
init discussion on admin discord: https://discord.com/channels/321003439431745537/382120794718732288/1458555076728848597
How did you test this change?
to be done