Skip to content

refactor(infobox): clean up chronology widget #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eetwalt merged 3 commits into from
Jan 14, 2026
Merged

refactor(infobox): clean up chronology widget #6956

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dead236
kick fragment
ElectricalBoy Jan 8, 2026
24adc04
reduce indentation
ElectricalBoy Jan 8, 2026
c9e6441
type annotation
ElectricalBoy Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions lua/wikis/commons/Widget/Infobox/Chronology.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,40 +29,38 @@ Chronology.defaultProps = {
showTitle = false,
}

---@return Widget?
---@return Widget[]?
function Chronology:render()
local links = self.props.links
if Logic.isEmpty(links) then
return
end

return HtmlWidgets.Fragment{
children = WidgetUtil.collect(
Logic.readBool(self.props.showTitle) and Title{children = self.props.title} or nil,
Array.map(self.props.links, Chronology._createChronologyRow)
)
}
return WidgetUtil.collect(
Logic.readBool(self.props.showTitle) and Title{children = self.props.title} or nil,
Array.map(self.props.links, Chronology._createChronologyRow)
)
end

---@param links {previous: {link:string, text: string}?, next: {link:string, text: string}?}
---@return Widget?
function Chronology._createChronologyRow(links)
if Logic.isEmpty(links) then return end

---@param mode 'previous'|'next'
---@return Widget?
local makeCell = function(mode)
if not links[mode] then return end
return Div{
classes = {'infobox-cell-2', 'infobox-text-' .. (mode == 'previous' and 'left' or 'right')},
children = {
InlineIconAndText{
children = InlineIconAndText{
link = links[mode].link,
text = links[mode].text,
icon = IconFa{
iconName = mode,
link = links[mode].link,
text = links[mode].text,
icon = IconFa{
iconName = mode,
link = links[mode].link,
},
flipped = mode ~= 'previous',
}
},
flipped = mode ~= 'previous',
}
}
end
Expand Down
Loading