-
Notifications
You must be signed in to change notification settings - Fork 100
feat(infobox): standardize dota2 version infobox #6950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Array.forEach( | ||
| Array.filter(Array.parseCommaSeparatedString(args.highlights, '\n?*'), String.isNotEmpty), | ||
| function (highlight, highlightIndex) | ||
| args['highlight' .. highlightIndex] = highlight | ||
| end | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't we bot this instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo it's better to bot after standardizing (wikicode version doesn't support |highlightX= input)
56cf34e to
c9cb3c1
Compare
Eetwalt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but will probably leave be this until Rath can take a look
Summary
This PR replaces wikicode-based fandom version of Template:Version infobox with standardized patch infobox.
How did you test this change?
https://liquipedia.net/dota2/User:ElectricalBoy/Sandbox2