-
Notifications
You must be signed in to change notification settings - Fork 100
feat(match2): display more info about each round in valorant matchpage #6947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
527fc26 to
7d74fc3
Compare
4ef56d6 to
e20e12f
Compare
763624f to
a473c65
Compare
a1017e5 to
5ecfecc
Compare
|
Love the idea, couple of suggestion purely for visuals:
Basically I would like to make the cards as close to some of the newer designs we have had so we're slowly aligning everything design wise. I can also make these changes in another branch if you like so we can compare? |
actually Delightify already came up with a nice design (much better than my janky one if you ask me :p) so I am planning to rework this PR in a day or two https://discord.com/channels/93055209017729024/1356577556567953550/1458756412837466208 |
|
Nice! Yeah looks great |
Eetwalt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, tested locally and looks like designed.
Summary
This PR adds round-by-round details display to valorant match pages.
Remark
The initial version of this PR used carousel widget but it was eventually replaced with custom css classes due to #6951.
How did you test this change?
valorant:Match:ID User ElectricalBoy UN8hyPZqOA R01-M001 + browser dev tools
see Discord for screenshots