Skip to content

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Jan 5, 2026

Summary

This PR adds round-by-round details display to valorant match pages.

Remark

The initial version of this PR used carousel widget but it was eventually replaced with custom css classes due to #6951.

How did you test this change?

valorant:Match:ID User ElectricalBoy UN8hyPZqOA R01-M001 + browser dev tools

see Discord for screenshots

@ElectricalBoy ElectricalBoy added g: valorant VALORANT c: match2 stylesheets Changes to stylesheets labels Jan 5, 2026
@ElectricalBoy ElectricalBoy force-pushed the valorant-matchpage-round-detail branch 4 times, most recently from 527fc26 to 7d74fc3 Compare January 7, 2026 06:37
@ElectricalBoy ElectricalBoy marked this pull request as ready for review January 7, 2026 06:42
@ElectricalBoy ElectricalBoy force-pushed the valorant-matchpage-round-detail branch from 4ef56d6 to e20e12f Compare January 7, 2026 08:51
@ElectricalBoy ElectricalBoy requested a review from hjpalpha January 7, 2026 09:01
@ElectricalBoy ElectricalBoy force-pushed the valorant-matchpage-round-detail branch 2 times, most recently from 763624f to a473c65 Compare January 7, 2026 09:22
@ElectricalBoy ElectricalBoy force-pushed the valorant-matchpage-round-detail branch from a1017e5 to 5ecfecc Compare January 7, 2026 09:25
@Eetwalt
Copy link
Collaborator

Eetwalt commented Jan 8, 2026

Love the idea, couple of suggestion purely for visuals:

  1. What if we use a toggle "Show round details" instead of the show/hide button? That way we don't have to have the extra box for Round details which looks a bit weird when closed. I guess the
  2. For the card designs, I would lose the colored bg for the round title, push the winner as the first row, Maybe un-bold the title texts and have the rows be alternating colors (same as team participant cards). Card bg could be white and the cards could have the same border as the team participant cards.

Basically I would like to make the cards as close to some of the newer designs we have had so we're slowly aligning everything design wise.

I can also make these changes in another branch if you like so we can compare?

@ElectricalBoy
Copy link
Collaborator Author

Basically I would like to make the cards as close to some of the newer designs we have had so we're slowly aligning everything design wise.

I can also make these changes in another branch if you like so we can compare?

actually Delightify already came up with a nice design (much better than my janky one if you ask me :p) so I am planning to rework this PR in a day or two

https://discord.com/channels/93055209017729024/1356577556567953550/1458756412837466208

@ElectricalBoy ElectricalBoy marked this pull request as draft January 8, 2026 10:59
@Eetwalt
Copy link
Collaborator

Eetwalt commented Jan 8, 2026

Nice! Yeah looks great

@ElectricalBoy ElectricalBoy marked this pull request as ready for review January 9, 2026 03:27
@ElectricalBoy ElectricalBoy requested a review from hjpalpha January 9, 2026 03:27
@ElectricalBoy ElectricalBoy requested a review from hjpalpha January 9, 2026 08:21
Copy link
Collaborator

@Eetwalt Eetwalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested locally and looks like designed.

@Eetwalt Eetwalt merged commit f4b1cc9 into main Jan 14, 2026
6 checks passed
@Eetwalt Eetwalt deleted the valorant-matchpage-round-detail branch January 14, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match2 g: valorant VALORANT stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants