Skip to content

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Jan 2, 2026

Summary

This PR:

  • removes margins specified for mainpage components, replacing them with a single gap rule
  • cleans up repetitive rules in banner stylesheet

How did you test this change?

browser dev tools

@ElectricalBoy ElectricalBoy requested a review from Eetwalt January 2, 2026 03:13
@ElectricalBoy ElectricalBoy added stylesheets Changes to stylesheets c: main_page labels Jan 2, 2026
@ElectricalBoy ElectricalBoy changed the title refactor(mainpage): use gap instead of margins refactor(mainpage): clean up mainpage styles Jan 2, 2026
@Eetwalt
Copy link
Collaborator

Eetwalt commented Jan 7, 2026

Margin between header banner and nav cards was 1.5rem, now 0.5rem. Margin between nav cards and container was 1rem, now 0.5rem. Looking at how this was designed, both should actually be 1.5rem. So I think we should make the gap: 1.5rem for mainpage-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: main_page stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants