add failure-is-critical arg to nextcloud-stats#1010
Open
Cyberes wants to merge 2 commits intoLinuxfabrik:mainfrom
Open
add failure-is-critical arg to nextcloud-stats#1010Cyberes wants to merge 2 commits intoLinuxfabrik:mainfrom
Cyberes wants to merge 2 commits intoLinuxfabrik:mainfrom
Conversation
When the nextcloud-stats check has timeout issues it tends to get buried in the dashboard since UNKNOWN is ranked a lower priority. The new timeout-is-critical arg makes any timeout return critical
Cyberes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
nextcloud-statscheck has any sort of failure it tends to get buried in the dashboard since UNKNOWN is ranked a lower priority. The new--failure-is-criticalarg makes any failure return critical without changing the existing behavior.