Open
Conversation
danyalberchtoldlf
force-pushed
the
feat/grafana-jwt
branch
from
7246a12 to
70f78ef
Compare
NavidSassan
requested changes
Mar 25, 2026
roles/grafana/defaults/main.yml
Outdated
| grafana__bitwarden_collection_id: '{{ lfops__bitwarden_collection_id | default() }}' | ||
| grafana__bitwarden_organization_id: '{{ lfops__bitwarden_organization_id | default() }}' | ||
| grafana__cookie_samesite: 'lax' | ||
| grafana__auth_jwt: false |
| # Enable or disable loading other base map layers | ||
| ;enable_custom_baselayers = true | ||
|
|
||
| {% if grafana__auth_jwt %} |
Member
There was a problem hiding this comment.
is this section normally in the OS's grafana.ini? if yes, then remove the if-statement and just set enabled to grafana__auth_jwt. would make comparing rpmnews easier
| owner: 'apache' | ||
| group: 'icingaweb2' | ||
| mode: '0640' | ||
| when: icingaweb2_module_grafana__auth_jwt |
Member
There was a problem hiding this comment.
Suggested change
| when: icingaweb2_module_grafana__auth_jwt | |
| when: 'icingaweb2_module_grafana__auth_jwt' |
same below
| type: 'RSA' | ||
| owner: 'apache' | ||
| group: 'icingaweb2' | ||
| mode: '0640' |
Member
There was a problem hiding this comment.
Suggested change
| mode: '0640' | |
| mode: 0o640 |
| mode: '0644' | ||
| when: icingaweb2_module_grafana__auth_jwt | ||
|
|
||
| - name: 'restart grafana' |
| {% if icingaweb2_module_grafana__auth_jwt %} | ||
| jwtEnable = "1" | ||
| jwtUser = "grafana-admin" | ||
| jwtIssuer = "https://{{ (icingaweb2_module_grafana__url | split('://'))[1] }}" |
Member
There was a problem hiding this comment.
could you use https://docs.ansible.com/projects/ansible/latest/collections/ansible/builtin/urlsplit_filter.html instead? in any case, use the FQCN for the filter
danyalberchtoldlf
force-pushed
the
feat/grafana-jwt
branch
from
2ffb851 to
dd3f4ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.