Skip to content

Comments

Unify INI values#3704

Open
hansu wants to merge 18 commits intoLinuxCNC:masterfrom
hansu:unify-ini-values
Open

Unify INI values#3704
hansu wants to merge 18 commits intoLinuxCNC:masterfrom
hansu:unify-ini-values

Conversation

@hansu
Copy link
Member

@hansu hansu commented Jan 17, 2026

Fixes #3238 and #2335.

To be done

@hansu hansu added the 2.10-candidate would be nice to have fixed in 2.10 label Jan 17, 2026
@zz912
Copy link
Contributor

zz912 commented Jan 17, 2026

* [ ]  Adapt [Gmoccapy - change spindle => spindle_0 in *.ini files #3488](https://github.com/LinuxCNC/linuxcnc/pull/3488)

Feel free remake (or close) #3488 how you need. Git is not my friend, so I cant help you.

#3488 also does:

  • INI file from PNCconf is more verbose in build_INI.py
  • correct MACHINE in 7_axis.ini
  • correct MACHINE in 6_axis.ini

@andypugh
Copy link
Collaborator

andypugh commented Feb 4, 2026

update_ini is designed to be scriptable, (-d and -f flags) and I think I had a meta-script that ran it on all the sample configs.
I probably can't find it any more, but I could have a look.

@hansu hansu force-pushed the unify-ini-values branch 2 times, most recently from ef0fb47 to 9cc5bac Compare February 4, 2026 14:20
@hansu
Copy link
Member Author

hansu commented Feb 4, 2026

update_ini is designed to be scriptable, (-d and -f flags) and I think I had a meta-script that ran it on all the sample configs. I probably can't find it any more, but I could have a look.

Yes that would be helpful. I only used tested with the -d option so far.
The renaming stuff is done so far, only some parts which moves or copy some values are missing.
And a bit refactoring maybe.
Also a little bug where it generates two [KINS] sections...

@andypugh
Copy link
Collaborator

andypugh commented Feb 4, 2026

Yes that would be helpful.

Sorry, I looked and it's nowhere obvious. It might be sat in a git stash somewhere, but I think it's probably been lost.

I doubt it was anything special, I am not much of a scripting wizard.

@hansu
Copy link
Member Author

hansu commented Feb 9, 2026

I copied now

  • [TRAJ]DEFAULT_LINEAR_VELOCITY -> [DISPLAY]DEFAULT_LINEAR_VELOCITY
  • [TRAJ]MIN_LINEAR_VELOCITY -> [DISPLAY]MIN_LINEAR_VELOCITY

The values are/will not be not used in TRAJ any more. Do you think we should delete them from TRAJ or keep them as a precaution ?

@c-morley
Copy link
Collaborator

c-morley commented Feb 9, 2026

Ate you sure they ate not used in the trajectory planner?
Iirc they are used in non trivial machines.

@hansu
Copy link
Member Author

hansu commented Feb 9, 2026

Ate you sure they ate not used in the trajectory planner? Iirc they are used in non trivial machines.

DEFAULT_LINEAR_VELOCITY I overlooked, but MIN_LINEAR_VELOCITY is couldn't find in the trajectory planner.

@c-morley
Copy link
Collaborator

c-morley commented Feb 9, 2026

Ahh yes DEFAULT is what I was recalling.

@hansu
Copy link
Member Author

hansu commented Feb 11, 2026

I think the script is ready for the first review.

@andypugh How do we handle the message boxes if upgrading from <1.0 to 1.2?
Is it too irritating when there are multiple LinuxCNC versions in the list like this?

grafik

@hansu hansu requested a review from andypugh February 11, 2026 18:25
@zz912
Copy link
Contributor

zz912 commented Feb 22, 2026

Hi Hans, when do you expect to finish this PR? I'm currently converting the spindle control from PWM to hm2_modbus. So I could test if there are any bugs when changing SPINDLE => SPINDLE_0.

@hansu hansu marked this pull request as ready for review February 22, 2026 13:44
@hansu
Copy link
Member Author

hansu commented Feb 22, 2026

It's more or less ready from my side. This is waiting for a review and then all the INI files needs to be converted by the update_ini script and committed.
But this will be done just before 2.10 is being released I guess.

@zz912
Copy link
Contributor

zz912 commented Feb 22, 2026

I asked the wrong question.
When do you expect to merge this PR to master?
I'm currently working on hm2_modbus communication.
If it were merged in a few days. I'd wait for that.

I'm just asking. I don't want to do it twice.

@hansu
Copy link
Member Author

hansu commented Feb 22, 2026

I think it will take some weeks

@zz912
Copy link
Contributor

zz912 commented Feb 22, 2026

Ok, thanks for information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.10-candidate would be nice to have fixed in 2.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify INI file settings in DISPLAY section

4 participants