Skip to content

Fix data loss on writes larger than the tape block size #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matejk wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix data loss on writes larger than the tape block size #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/iosched/unified.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,11 @@ ssize_t _unified_insert_new_request(const char *buf, off_t offset, size_t count,
if (new_req->offset + new_req->count > dpr->file_size)
dpr->file_size = new_req->offset + new_req->count;

return (ssize_t)count;
/* Only copy_count bytes were stored (one cache block at most); the
* caller's append loop must advance by that, not the full count, or
* everything past the first block of a larger-than-blocksize write is
* silently dropped. */
return (ssize_t)copy_count;
}

/**
Expand Down
Loading