feat(xml): implement XML-DSig signing in DpsSigner#8
Merged
vitormattos merged 2 commits intomainfrom Mar 22, 2026
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the full XML-DSig enveloped signature in
DpsSigner, completing the Phase 2 signing deliverable.Previously
signXml()was a stub that returned unsigned XML; signing material was computed but immediately discarded.Changes
src/Xml/DpsSigner.phpsign(): keys returned byimportPfx()are now passed tosignXml()instead of being discarded viaunset()signXml(string $xml, string $privateKeyPem, string $certificatePem):@Id(infDPS) as the signed referenceDigestValue<Signature>inhttp://www.w3.org/2000/09/xmldsig#namespace with:CanonicalizationMethod— Canonical XML 1.0SignatureMethod— RSA-SHA1Referencewith enveloped-signature + C14N transformsDigestMethod(SHA-1) +DigestValueSignedInfoand RSA-SHA1 signs it viaopenssl_sign()SignatureValue(base64-encoded RSA output)KeyInfo > X509Data > X509Certificate(base64-encoded cert, no PEM headers)tests/Unit/Xml/DpsSignerTest.php(new)7 unit tests using an ephemeral RSA-2048 / self-signed PFX generated in
setUp():testSignReturnsXmlContainingSignatureElementtestSignReturnsXmlContainingDigestValuetestSignReturnsXmlContainingSignatureValuetestSignReturnsXmlContainingX509CertificatetestSignThrowsPfxImportExceptionWhenFileNotFoundtestSignedXmlIsStillValidXmltestSignatureElementIsAppendedToDpsRoot(XPath assertion:/DPS/ds:Signaturelength = 1)Test count: 32 → 39 unit tests
Gates