feat(xml): add tomador block and regEspTrib to XmlBuilder#7
Merged
vitormattos merged 2 commits intomainfrom Mar 22, 2026
Merged
feat(xml): add tomador block and regEspTrib to XmlBuilder#7vitormattos merged 2 commits intomainfrom
vitormattos merged 2 commits intomainfrom
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
XmlBuilder::buildDps()to include the tomador (buyer) block and optional regime especial de tributação, completing the DPS XML coverage for common NFS-e issuance scenarios.Changes
src/Xml/XmlBuilder.phpbuildToma()— new private helper that builds<toma>block:documentoTomador→<CNPJ>...</CNPJ>documentoTomador→<CPF>...</CPF>nomeTomadormapped to<xNome>(XML-escaped)<toma>block is omitted entirely whendocumentoTomadoris empty (foreign buyers)regEspTribelement appended toinfDPSwhenregimeEspecialTributacao !== nulltests/Unit/Xml/XmlBuilderTest.php5 new tests using
DOMXPathfor structural assertion:testTomadorCnpjBlockIsIncludedWhenDocumentHas14DigitstestTomadorCpfBlockIsIncludedWhenDocumentHas11DigitstestTomadorBlockIsAbsentWhenDocumentoTomadorIsEmptytestRegimeEspecialTributacaoIsIncludedWhenSettestRegimeEspecialTributacaoIsAbsentWhenNullmakeDps()test helper extended withdocumentoTomador,nomeTomador,regimeEspecialTributacaoparams (all optional with safe defaults).Test count: 27 → 32 unit tests
Gates