test: CLI fallback extracts PEM from PFX via -legacy flag#11
Merged
vitormattos merged 1 commit intomainfrom Mar 23, 2026
Merged
test: CLI fallback extracts PEM from PFX via -legacy flag#11vitormattos merged 1 commit intomainfrom
vitormattos merged 1 commit intomainfrom
Conversation
… flag Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unit test for
DpsSigner::extractLegacyPemMaterial()via reflection.The test creates a modern PFX using
openssl_pkcs12_export(), then callsextractLegacyPemMaterial()directly (via reflection) to verify the CLI fallback correctly extracts both the private key PEM and certificate PEM.The
openssl pkcs12 -legacyflag supports both legacy and modern PFX files, so the test exercises the full CLI fallback path end-to-end.Coverage
DpsSigner::extractLegacyPemMaterial()— CLI-based legacy PFX extraction viaopenssl pkcs12 -legacy