Skip to content

fix: always try CLI fallback after native PFX import failure#10

Merged
vitormattos merged 1 commit intomainfrom
fix/native-import-fallback-always-on-cli
Mar 22, 2026
Merged

fix: always try CLI fallback after native PFX import failure#10
vitormattos merged 1 commit intomainfrom
fix/native-import-fallback-always-on-cli

Conversation

@vitormattos
Copy link
Member

Summary

  • always try OpenSSL CLI extraction after native PKCS#12 import failure
  • keep native OpenSSL error details when both native and CLI paths fail
  • make import robust against varying OpenSSL error queues such as nested ASN.1 errors

Why

The same legacy PFX can surface different native OpenSSL errors depending on context, including digital envelope unsupported and nested ASN.1 errors.
Restricting the fallback trigger to a single error string still allowed emission failures in the web flow.

Validation

  • real signing smoke test passed with the stored production-like certificate
  • module PHPUnit suite passed after the change
  • PHP service was restarted so the local web runtime now uses the updated package code

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos merged commit 934fc9a into main Mar 22, 2026
10 checks passed
@vitormattos vitormattos deleted the fix/native-import-fallback-always-on-cli branch March 22, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant