Skip to content

Conversation

@lucs7
Copy link
Contributor

@lucs7 lucs7 commented Sep 17, 2025

Important

This commit fill fail in testing workflow as tox location was changed to ./ci/ which requires a readthedocs.yml update

  • Refactored ci/config-check.py to compare config keys in config.dist.php with required environment variables in .env.example, ensuring all config keys are covered.
  • Added new script ci/configKeys-check.py to verify that all keys in config.dist.php are defined in ConfigKeys.php, preventing missing configuration definitions.
  • Updated tox.ini to use the new config check scripts for linting and configuration validation.

CI/CD Workflow Improvements:

  • Refactored .github/workflows/lint-and-analyse-php.yml to improving job clarity and dependencies. Added workflow_dispatch for manual runs and optimized Composer caching.

Code Quality Tooling:

  • Added friendsofphp/php-cs-fixer and php-parallel-lint as dev dependencies in composer.json. Updated Composer scripts to use these tools for linting and code style checks.

@lucs7 lucs7 marked this pull request as ready for review September 17, 2025 15:11
@lucs7 lucs7 marked this pull request as draft September 17, 2025 15:16
@lucs7 lucs7 force-pushed the feature/ci-and-env-split branch 3 times, most recently from 1cde23c to c20554c Compare September 18, 2025 08:12
@lucs7 lucs7 marked this pull request as ready for review September 18, 2025 15:32
@JohnVillalovos
Copy link
Contributor

@lucs7 Can the .readthedocs.yml file be updated to point at the new location for the requirements file?

lucs7 added 6 commits October 15, 2025 22:20
- added php-parallel-linter for improved linting performance
- removed deprecated ci/ci-phplint script
- updated composer.json scripts for better usability
- modified GitHub Actions workflow for streamlined CI process
- added cs2pr for better readability
@JohnVillalovos JohnVillalovos force-pushed the feature/ci-and-env-split branch from c20554c to b5399d8 Compare October 16, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants