Add TestFileUtils.deleteDirWithRetry method.#2946
Open
labkey-danield wants to merge 11 commits intorelease26.3-SNAPSHOTfrom
Open
Add TestFileUtils.deleteDirWithRetry method.#2946labkey-danield wants to merge 11 commits intorelease26.3-SNAPSHOTfrom
labkey-danield wants to merge 11 commits intorelease26.3-SNAPSHOTfrom
Conversation
No need to wait for the search indexer.
labkey-jeckels
added a commit
to LabKey/platform
that referenced
this pull request
Apr 14, 2026
…#7578) #### Rationale We read transform scripts during assay design save. We open but don't close the file. This is impolite, and Windows automated tests have been noticing. https://teamcity.labkey.org/buildConfiguration/LabKey_263Release_Premium_CommunitySqlserver_DailyCSqlserver/3929893?buildTab=tests&status=failed&expandedTest=build%3A%28id%3A3929893%29%2Cid%3A2000000048 #### Related Pull Requests - LabKey/testAutomation#2946 #### Changes - try-with-resources is the polite way to handle InputStreams <!-- list of standard tasks (remove this comment to enable) #### Tasks 📍 - [ ] Manual Testing - [ ] Needs Automation - [ ] Verify Fix -->
…egression to what it was originally. Move the delete and retry code in to TestFileUtils.deleteDirWithRetry
labkey-danield
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Revert AssayTransformMissingParentDirTest.testMissingParentDirectoryRegression to (mostly) its original state.
Move the delete code into TestFileUtils.deleteDirWithRetry, this might be useful to help debug failures in the future.
Related Pull Requests
Changes