-
Notifications
You must be signed in to change notification settings - Fork 10
Spring AI version #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Spring AI version #1259
Conversation
|
Looks like we need to resolve some conflicting dependency versions. org.antlr:ST4 has 2 versions as follows: |
# Conflicts: # gradle.properties
| springBootVersion=3.5.8 | ||
| # This usually matches the Spring Framework version dictated by springBootVersion | ||
| springVersion=6.2.15 | ||
| springAiVersion=1.1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this at the root? Looks like it's only used in the API module. Do you expect other modules will need it before long?
Regardless, we need to resolve the handful of dependency version conflicts before this can be merged.
labkey-jeckels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to resolve dependency conflicts
I put springAIVersion here just to put it with its spring friends. I'm open to doing something else. I forced force antlrST4Version=4.3.4 (in platform). Seems to work, but I'm not sure how we maintain and review these exceptions. |
I believe we primarily rely on the comments in the line that forces the version. Thanks for adding one. @labkey-susanh any preference on where to set the Spring AI version? I thought it would live in the one module that uses it, but I don't see a |
|
@labkey-matthewb that cleared one of the four conflicts. We probably need forces for one or more of the others too. |
Often if there's just one usage, we won't capture it in a |
@labkey-matthewb here's the link to that "Upgrade Dependencies" doc: https://docs.google.com/document/d/1JPZ8al_M6eQh813Q8y3ALhRNgTieveaKDXv5iFUbq7A/edit?tab=t.0 |
Rationale
set global dependency version
Related Pull Requests
Changes