Conversation
labkey-jeckels
left a comment
There was a problem hiding this comment.
Change seems fine. There are test failures, which may be unrelated.
A lot of maintenance tasks will fail with this change. They construct Users out of thin air and didn't set them active, which means they no longer have permission to do what they need to do. I think we should switch them to something more formal, like SystemUser that takes a name and sets everything standard. Or maybe switch them all to use the standard system user. |
labkey-tchad
left a comment
There was a problem hiding this comment.
Manual testing looks good.
FileLinkMetricsMaintenanceTask seems to be the only system maintenance task that's getting tripped up by this change. No server-side JUnit tests are having problems.
Rationale
https://github.com/LabKey/internal-issues/issues/497
Changes