Rename tables and columns with names that are too long for PostgreSQL#7458
Open
labkey-adam wants to merge 5 commits intodevelopfrom
Open
Rename tables and columns with names that are too long for PostgreSQL#7458labkey-adam wants to merge 5 commits intodevelopfrom
labkey-adam wants to merge 5 commits intodevelopfrom
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum,
labkey-martyp and
labkey-matthewb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Microsoft SQL Server allows table and column names that are longer than what PostgreSQL allows (128 characters vs. 63 UTF8 bytes). Long names on SQL Server can foul up the SQL Server to PostgreSQL migration process. We address this by renaming all existing SQL Server long table/column names and updating SQL Server to produce PostgreSQL-compatible names going forward.
https://github.com/LabKey/internal-issues/issues/869