Update of eIACUC ETL removed 3 steps for unused queries#1751
Open
ohsudev-jonesga wants to merge 5 commits into
Open
Update of eIACUC ETL removed 3 steps for unused queries#1751ohsudev-jonesga wants to merge 5 commits into
ohsudev-jonesga wants to merge 5 commits into
Conversation
brentlogan
reviewed
Jun 9, 2026
brentlogan
reviewed
Jun 9, 2026
Collaborator
There was a problem hiding this comment.
Transfers from eIACUCProd.eIACUC tables to onprc_ehr.eIACUC_PRIME_VIEW_* tables
brentlogan
reviewed
Jun 9, 2026
| @@ -7,7 +7,7 @@ | |||
brentlogan
reviewed
Jun 9, 2026
| <destination queryName="eIACUC_PRIME_VIEW_NON_SURGICAL_PROCS" schemaName="ONPRC_EHR" targetOption="truncate"/> | ||
| </transform> | ||
| </transform>--> | ||
| <transform id="step4a"> |
brentlogan
reviewed
Jun 9, 2026
| </transform> | ||
| </transform>--> | ||
| <transform id="step4a"> | ||
| <description>Transfer to Protocols</description> |
brentlogan
reviewed
Jun 9, 2026
| <destination queryName="eIACUC_PRIME_VIEW_SURGICAL_PROCS" schemaName="ONPRC_EHR" targetOption="truncate"/> | ||
| </transform> | ||
| </transform>--> | ||
| <transform id="UpdateBaseProtocol" type="StoredProcedure"> |
brentlogan
reviewed
Jun 9, 2026
| </transform> | ||
| </transform>--> | ||
| <transform id="UpdateBaseProtocol" type="StoredProcedure"> | ||
| <description>Determines and populates BaseProtocol and RevisionNumber data for the protocol table in schema onprc_ehr.</description> |
Collaborator
There was a problem hiding this comment.
Create BaseProtocol and RevisionNumber for Protocols
Collaborator
Author
There was a problem hiding this comment.
I will remove the unneeded steps and change the step numbers and resubmit
brentlogan
reviewed
Jun 9, 2026
Collaborator
There was a problem hiding this comment.
No description provided.
brentlogan
reviewed
Jun 9, 2026
Collaborator
There was a problem hiding this comment.
Remove the "0" from "04"
brentlogan
requested changes
Jun 9, 2026
brentlogan
left a comment
brentlogan
left a comment
Collaborator
There was a problem hiding this comment.
I have a bunch of nit-picky comments, but this is our easy opportunity to fix these before we get a build.
Updated the ETL configuration for eIACUC to Prime transfer, including changes to names and descriptions.
ohsudev-jonesga
commented
Jun 10, 2026
ohsudev-jonesga
left a comment
ohsudev-jonesga
left a comment
Collaborator
Author
There was a problem hiding this comment.
As Expected
Removed a "special" character in description in an attempt to get past automated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Based on Changed by LabKey, review was completed and determined that there were steps in the eIACUC to Prime ETL that could be removed without issue.
Related Pull Requests
Changes
Removed 3 steps in ETL Process and updated etl eIACUCtoPrime.xml