-
Notifications
You must be signed in to change notification settings - Fork 2
Provisional Nucleotide Sequences #1945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
labkey-alan
wants to merge
12
commits into
develop
Choose a base branch
from
fb_provisional_ns
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5166c87
Remove app-page styles (moved to ui-premium)
labkey-alan 0ddb509
Add ta-left, ta-right util styles
labkey-alan a7ad8ec
Updat release notes
labkey-alan 12df3c7
Popover: lint file
labkey-alan 68efec7
PageDetailHeader: add deprecation comment
labkey-alan 7520ed4
Update build to use pyproject.toml and hatch
labkey-alan 8bd476f
Add UnidentifiedPill, EMPTY_SEQUENCE_WARNING
labkey-alan 007592b
NodeDetailHeader: Render UnidentifiedPill for unidentified sequences
labkey-alan eb0335d
LineageNodeMetadata: use value for alias column
labkey-alan f02217d
Add hasSequenceCol, use it in NodeDetailHeader
labkey-alan ac23a2c
NodeDetailHeader: don't render alias, description. Move unidentified …
labkey-alan 67ff3a9
PR feedback
labkey-alan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import React, { FC, useMemo } from 'react'; | ||
| import { createPortal } from 'react-dom'; | ||
| import { generateId } from './util/utils'; | ||
| import { useOverlayTriggerState } from './OverlayTrigger'; | ||
| import { Popover } from './Popover'; | ||
| import { EMPTY_SEQUENCE_WARNING } from './constants'; | ||
|
|
||
| export const UnidentifiedPill: FC = () => { | ||
| const id = useMemo(() => generateId('unidentified-sequence-overlay-trigger'), []); | ||
| // Note: we use useOverlayTriggerState instead of OverlayTrigger because the wrapping div from OverlayTrigger | ||
| // causes layout problems. | ||
| const { onMouseEnter, onMouseLeave, portalEl, show, targetRef } = useOverlayTriggerState(id, true, false); | ||
|
|
||
| const popover = useMemo( | ||
| () => ( | ||
| <Popover id="unidentified-sequence-popover" placement="top" targetRef={targetRef}> | ||
| <div className="unidentified-sequence-popover">{EMPTY_SEQUENCE_WARNING}</div> | ||
| </Popover> | ||
| ), | ||
| [targetRef] | ||
| ); | ||
|
|
||
| return ( | ||
| <div | ||
| className="status-pill info unidentified-sequence-pill" | ||
| onMouseEnter={onMouseEnter} | ||
| onMouseLeave={onMouseLeave} | ||
| ref={targetRef} | ||
| > | ||
| Unidentified | ||
| <span className="label-help-icon fa fa-question-circle" /> | ||
| {show && createPortal(popover, portalEl)} | ||
| </div> | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 15 additions & 42 deletions
57
packages/components/src/internal/components/lineage/node/LineageDetail.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.