GitHub #503: Add option to open URL links in a new tab in the domain designer UI (LabKey Issue: 54178) #1919
Conversation
cnathe
changed the title
packages/components/src/internal/components/domainproperties/models.tsx
Outdated
Show resolved
Hide resolved
| required: false, | ||
| scale: MAX_TEXT_LENGTH, | ||
| URL: undefined, | ||
| URLTarget: undefined, |
There was a problem hiding this comment.
I think the original feature request prefers new URL to default to '_blank'. If not implemented we should probably note that in the issue.
There was a problem hiding this comment.
after feature verification with Hannah, we decided to not default this checkbox to checked (especially since it starts out disabled until the user enters a URL value)
| className="form-control domain-text-option-urltarget" | ||
| checked={field.URLTarget === '_blank'} | ||
| onChange={this.handleURLTargetChange} | ||
| disabled={isFieldFullyLocked(field.lockType) || isEmptyString(field.URL)} |
There was a problem hiding this comment.
I find it strange that if there is an XML setting (which has higher priority), that we still allow editing of target in UI. But maybe that's too much work?
There was a problem hiding this comment.
Yeah, I agree but that is the case for all field properties. The field editor doesn't know about any XML metadata overrides (those are applied server side after the fact). The getDomainDetails API gets the domain field info as stored in the DB. It would be odd / confusing if that API returned the XML overrides with the response.
Rationale
#503 LKSM: Add option to open URL links in a new tab in the domain designer UI (LabKey Issue: 54178)
Related Pull Requests
Changes