GitHub Issue 774: Fix distribution file name for snapshot versions #240
Conversation
… git commands instead of versioning plugin that is no longer used
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
BuildUtils.getVersionNumber also references the versioning plugin. Could you update that as well? If I remember correctly, it's used to include feature branch names in module.xml files for modules built from a feature branch.
| if (distributionProject.configurations.named(config) == null) | ||
| distributionProject.configurations { | ||
| config | ||
| } |
There was a problem hiding this comment.
I think this could use maybeCreate.
distributionProject.configurations.maybeCreate(config)
|
|
||
| distributionProject.evaluationDependsOn(depProject.getPath()) | ||
| if (depProject.configurations.findByName("modules") != null) { | ||
| if (depProject.configurations.named("modules") != null) { |
There was a problem hiding this comment.
I don't think this will work the same way. named throws an exception instead of returning null.
There's no advantage to using lazy resolution here since we're immediately digging in to the configuration's contents, right?
There was a problem hiding this comment.
Ah, you are so right. I forgot about that. (You would think I might remember since it's really annoying that this throws an exception).
|
After some investigation, it turns out |
I've restored the functionality for now. I think it's still at least theoretically desirable, even if we are seldom using |
Rationale
Issue 774: When we removed the usage of the versioning plugin, we missed a dependency on that plugin that was used for determining the names of our distribution files.
The
RestoreFromTrashtask needed converting to be compatible with the configuration cache and to allow for a more robust restoration process.The
PurgeArtifactstask was not checking for empty versions, and if purge requests are sent with an empty version, that causes all versions to be deleted. Not something we want.Related Pull Requests
Changes
BuildUtils.getDistributionVersionto get VCS properties from git commands instead of removed versioning pluginPurgeArtficatstaskRestoreFromTrashtask to read modules and versions from files