Skip to content

ImpersonationContext -> PermissionsContext rename/repackage #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-adam wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ImpersonationContext -> PermissionsContext rename/repackage #1105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions snd/src/org/labkey/snd/security/SNDSecurityManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@
import org.labkey.api.query.ValidationException;
import org.labkey.api.security.Group;
import org.labkey.api.security.MutableSecurityPolicy;
import org.labkey.api.security.PermissionsContext;
import org.labkey.api.security.SecurityManager;
import org.labkey.api.security.SecurityPolicy;
import org.labkey.api.security.SecurityPolicyManager;
import org.labkey.api.security.User;
import org.labkey.api.security.impersonation.ImpersonationContext;
import org.labkey.api.security.impersonation.RoleImpersonationContextFactory;
import org.labkey.api.security.permissions.Permission;
import org.labkey.api.security.roles.Role;
Expand Down Expand Up @@ -218,8 +218,8 @@ private boolean hasPermission(User u, Category category, QCStateActionEnum actio
// SND has permissions bound to SND categories which can be assigned to packages (domains). Impersonating roles is used
// in automated and manual testing to verify this behavior. The behavior of role impersonation was changed in core
// labkey to only check for roles related to containers. This is a workaround to go back to checking all roles.
ImpersonationContext impersonationContext = u.getImpersonationContext();
if (impersonationContext instanceof RoleImpersonationContextFactory.RoleImpersonationContext context)
PermissionsContext permissionsContext = u.getPermissionsContext();
if (permissionsContext instanceof RoleImpersonationContextFactory.RoleImpersonationContext context)
{
roles = context.getRoles().getRoles();
}
Expand Down