GitHub Issue 875: Luminex Multi-File Transform Import Skips First Data Row#986
GitHub Issue 875: Luminex Multi-File Transform Import Skips First Data Row#986cnathe wants to merge 4 commits intorelease25.11-SNAPSHOTfrom
Conversation
…fy total row count after multi file run import
…ay design (so we test both)
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
Let's discuss the benefits and drawbacks to using fuzz in this way.
| LuminexMultipleCurvesTest init = getCurrentTest(); | ||
|
|
||
| // add the R transform script to the assay, fuzz testing so we test with and without the transform script | ||
| boolean shouldAddTransformScript = TestDataGenerator.randomBoolean(); |
There was a problem hiding this comment.
I'm a little conflicted about this. I'm not sure that it is better to have a dedicated test, or to randomly select (like you do here), or alternate based on the date (or some other criteria).
I see the advantages to using the fuzz testing here. A dedicate test would be a duplicate and have a lot of set up for minimal functional testing.
One disadvantage to this approach is that it assumes the person doing Test Status knows about this. They might run the test locally, it passes, and they then say "must be random, I'll see how it does tomorrow", and then it passes on the next TC run.
At minimum the test should log weather or not it is adding a transform script.
Maybe we can discuss a little bit about benefits and disadvantages.
There was a problem hiding this comment.
I did just push the change to include the logging for the randomBoolean case. Ping me when you are free to chat about this approach more generally.
2 participants
Rationale
#875 Luminex Multi-File Transform Import Skips First Data Row
See related PR for rationale. This PR updates the Luminex test case to check for the expected number of total rows after a multi file assay run import. It also fuzzes whether or not a no-op R transform script is added to the assay design so that we test both code paths for an assay import (with and without transform script).
Related Pull Requests
Changes