Skip to content

Commit fe0661a

Browse files
committed
Minor code cleanup
1 parent 2a6016a commit fe0661a

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

SequenceAnalysis/src/org/labkey/sequenceanalysis/analysis/UpdateReadsetFilesHandler.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,18 +131,18 @@ private SAMFileHeader getAndValidateHeaderForBam(SequenceOutputFile so, String n
131131
Set<String> distinctLibraries = rgs.stream().map(SAMReadGroupRecord::getLibrary).collect(Collectors.toSet());
132132
if (distinctLibraries.size() > 1)
133133
{
134-
throw new PipelineJobException("File has more than one library in read group(s), found: " + distinctLibraries.stream().collect(Collectors.joining(", ")));
134+
throw new PipelineJobException("File has more than one library in read group(s), found: " + String.join(", ", distinctLibraries));
135135
}
136136

137137
Set<String> distinctSamples = rgs.stream().map(SAMReadGroupRecord::getSample).collect(Collectors.toSet());
138138
if (distinctSamples.size() > 1)
139139
{
140-
throw new PipelineJobException("File has more than one sample in read group(s), found: " + distinctSamples.stream().collect(Collectors.joining(", ")));
140+
throw new PipelineJobException("File has more than one sample in read group(s), found: " + String.join(", ", distinctSamples));
141141
}
142142

143143
if (
144-
distinctLibraries.stream().filter(x -> !x.equals(newRsName)).count() == 0L &&
145-
distinctSamples.stream().filter(x -> !x.equals(newRsName)).count() == 0L
144+
distinctLibraries.stream().allMatch(x -> x.equals(newRsName)) &&
145+
distinctSamples.stream().allMatch(x -> x.equals(newRsName))
146146
)
147147
{
148148
throw new PipelineJobException("Sample and library names match in read group(s), aborting");

SequenceAnalysis/src/org/labkey/sequenceanalysis/pipeline/CacheGenomePipelineJob.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ public List<String> getProtocolActionNames()
146146
}
147147

148148
@Override
149-
public PipelineJob.Task createTask(PipelineJob job)
149+
public PipelineJob.Task<?> createTask(PipelineJob job)
150150
{
151151
return new CacheGenomesTask(this, job);
152152
}

singlecell/resources/web/singlecell/panel/PoolImportPanel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ Ext4.define('SingleCell.panel.PoolImportPanel', {
299299
},
300300

301301
hto: function(val, panel){
302-
if (val === 'N/A' || val === 'NA') {
302+
if (val === 'N/A' || val === 'NA' || val === 'N') {
303303
return null;
304304
}
305305

0 commit comments

Comments
 (0)