Skip to content

Commit fa50992

Browse files
committed
Allow nimble plot to run and not produce an HTML file
1 parent a569b46 commit fa50992

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

singlecell/src/org/labkey/singlecell/run/NimbleHelper.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -292,17 +292,9 @@ public void doNimbleAlign(File bam, PipelineStepOutput output, Readset rs, Strin
292292

293293
output.addSequenceOutput(results, basename + ": nimble align", "Nimble Results", rs.getRowId(), null, genome.getGenomeId(), description);
294294

295+
// NOTE: situations like zero alignments would result in no report being created. Rely on the code in doAlign to verify proper execution of nimble
295296
File reportHtml = getReportHtmlFileFromResults(results);
296-
if (!reportHtml.exists())
297-
{
298-
if (SequencePipelineService.get().hasMinLineCount(results, 2))
299-
{
300-
long lineCount = SequencePipelineService.get().getLineCount(results);
301-
_ctx.getLogger().debug("Found {} lines in file {}", lineCount, results.getPath());
302-
throw new PipelineJobException("Unable to find file: " + reportHtml.getPath());
303-
}
304-
}
305-
else
297+
if (reportHtml.exists())
306298
{
307299
output.addSequenceOutput(reportHtml, basename + ": nimble report", NIMBLE_REPORT_CATEGORY, rs.getRowId(), null, genome.getGenomeId(), description);
308300
}
@@ -554,7 +546,7 @@ public static File runNimbleReport(File alignResultsGz, int genomeId, PipelineSt
554546

555547
if (!plotResultsHtml.exists())
556548
{
557-
throw new PipelineJobException("Missing file: " + plotResultsHtml.getPath());
549+
ctx.getLogger().info("No report HTML generated, but nimble plot had exit code 0");
558550
}
559551
}
560552
else

0 commit comments

Comments
 (0)