Use metadata from the library for remote tracks when possible. #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows remote track metadata comparisons to be done using data from the library, if available, reducing overhead when checking for replay gain or sample rate changes during track transition. Aside from increasing performance, it also eliminates Smart Gain calculation errors caused by the unavailability of remote metadata that has expired from the remote handler's cache, a problem that has plagued the Qobuz plugin. Signed-off-by: Sam Y <syahres@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows remote track metadata comparisons to be done using data from the library, if available, reducing overhead when evaluating Smart Gain, Smart Crossfade, or sample rate changes during track transition. Aside from increasing performance, it also eliminates errors in these evaluations caused by the unavailability of remote metadata that has expired from the remote handler's cache, a problem that has plagued the Qobuz plugin.