Skip to content

Conversation

@sakertooth
Copy link
Contributor

@sakertooth sakertooth commented Feb 21, 2024

The option to export a track was added to the cog wheel for anything but automation tracks. Users are presented with a file dialog for the output location and then the export dialog to specify the output configuration.

Future

This PR previously was for exporting clips as well, but this would require some refactor to do appropriately. This feature reuses some of the functionality already in RenderManager, but the problem is that we will eventually have 3-4 different export modes to choose from, which means a possibility for a lot of conditional branching and complexity.

My idea for a refactor might be to have a general ExportContext object, which holds the list of tracks and the time range to export, as well as if the tracks should be consolidated into one file or rendered into multiple files. This general approach should cover all the export modes we need, which will help streamline the RenderManager code and reduce complexity. This is just my idea for now, its subject to change.

Notes for Testers

If testing, test that:

  • The file dialog shows as expected when exporting the project, individual tracks, or a single track
  • Switching the file type in the file dialog correctly switches the extension in the file name if the file name hasn't been changed
  • The extension in the selected file name in the file dialog correctly matches the chosen file format in the export dialog
  • The export settings work as usual (loop markers, add one bar, bit depth, bit rate etc)
  • The exported audio sounds as expected.

Fixes #6666.

@sakertooth sakertooth changed the title Add functionality to bounce a single track Add functionality to export a single track Feb 21, 2024
@Spacemagehq
Copy link

Spacemagehq commented Jan 15, 2025

I found a couple bugs for this pr there is an audio bug when you go to the volume tab in the instruments when you turn the amt on and all the way to the right the bounced audio/exported audio will get loud for no reason then go to normal volume. The other bug is the word cancel is cut off on Windows 11.
the cancel cut off two

the cancel cut off

@sakertooth
Copy link
Contributor Author

I found a couple bugs for this pr there is an audio bug when you go to the volume tab in the instruments when you turn the amt on and all the way to the right the bounced audio/exported audio will get loud for no reason then go to normal volume. The other bug is the word cancel is cut off on Windows 11.

Are you also sure these issues don't appear on the master branch?

@Spacemagehq
Copy link

I found a couple bugs for this pr there is an audio bug when you go to the volume tab in the instruments when you turn the amt on and all the way to the right the bounced audio/exported audio will get loud for no reason then go to normal volume. The other bug is the word cancel is cut off on Windows 11.

Are you also sure these issues don't appear on the master branch?

i'm on Windows, it's a pain in the ass to compile anything from scratch or build the master.

@sakertooth
Copy link
Contributor Author

i'm on Windows, it's a pain in the ass to compile anything from scratch or build the master.

Can't you simply install the nightly build?

Copy link
Contributor

@szeli1 szeli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add #8086 MidiClipView.h SampleClipView.h. You can improve them with ProjectRenderer::availableDescriptions()
Please apply the changes according to your opinion.

@sakertooth
Copy link
Contributor Author

Please also add #8086 MidiClipView.h SampleClipView.h. You can improve them with ProjectRenderer::availableDescriptions()

Please apply the changes according to your opinion.

Will try to apply this, thanks. It also might be easier to send me a git diff patch but I can work with the suggestions.

@sakertooth sakertooth changed the title Add functionality to export a single track Add functionality to export tracks and clips Oct 12, 2025
@sakertooth sakertooth marked this pull request as draft October 12, 2025 16:38
@sakertooth sakertooth changed the title Add functionality to export tracks and clips Add feature to export tracks and clips Oct 12, 2025
@sakertooth
Copy link
Contributor Author

I might do a refactor before this PR so it is easier to implement some stuff.

@sakertooth
Copy link
Contributor Author

We should also have this PR be able to export pattern tracks, which may not have a clip in the song editor.

image

@szeli1
Copy link
Contributor

szeli1 commented Oct 13, 2025

I might do a refactor before this PR so it is easier to implement some stuff.

What do you mean by this?

We should also have this PR be able to export pattern tracks, which may not have a clip in the song editor.

Maybe, it isn't a priority.

@sakertooth sakertooth requested a review from szeli1 October 26, 2025 18:57
Copy link
Contributor

@szeli1 szeli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this PR. I miss the "drag n drop" functionality my PR provided. This PR does exporting clips better than my PR which is nice.

@sakertooth sakertooth changed the title Add feature to export tracks and clips Add feature to export tracks Dec 12, 2025
@sakertooth sakertooth marked this pull request as ready for review December 12, 2025 14:47
@JohannesLorenz JohannesLorenz self-requested a review January 6, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Freeze audio to sample track

3 participants