-
Notifications
You must be signed in to change notification settings - Fork 3
Gh 96 adding status condition for openapispec #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: R-Lawton <rlawton@redhat.com>
Signed-off-by: R-Lawton <rlawton@redhat.com>
| if envMaxSize := os.Getenv("OPENAPI_SPEC_MAX_SIZE"); envMaxSize != "" { | ||
| if parsed, err := strconv.Atoi(envMaxSize); err == nil && parsed > 0 { | ||
| openAPIMaxSize = parsed | ||
| setupLog.Info("using custom OpenAPI spec max size", "size", openAPIMaxSize) | ||
| } else { | ||
| setupLog.Error(err, "invalid OPENAPI_SPEC_MAX_SIZE env var, using default", openAPIMaxSize) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was on the fence about adding this ability in but it was in the issue, feels a bit overkill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a nice-to-have feature rather than a requirement, but since it's already here, I think we can leave it in.
Signed-off-by: R-Lawton <rlawton@redhat.com> Fixed the tests Signed-off-by: R-Lawton <rlawton@redhat.com>
…d. Also some spelling mistakes Signed-off-by: R-Lawton <rlawton@redhat.com>
Signed-off-by: R-Lawton <rlawton@redhat.com>
Closes one part of Kuadrant/kuadrant-backstage-plugin#96
Changes:
#Verification
Update file size limit to 1024 via env var
OPENAPI_SPEC_MAX_SIZE=1024 make runYou should see in the conditions