[OptApp / SIApp] Updating the Expressions to TensorAdaptors by sunethwarna · Pull Request #14214 · KratosMultiphysics/Kratos

sunethwarna · 2026-02-17T13:03:36Z

📝 Description
This PR removes all the use cases of Expression in OptimizationApplication and SystemIdentificationApplication, and replaces them with new TensorAdaptors.

This requires following PRs to be merged first.

🆕 Changelog

Replaces the uses of Expression with TensorAdaptor

…_adaptor_update

Igarizza · 2026-03-09T19:43:08Z

            # model part
            return self.model_part.GetRootModelPart()

+    def __ExtractTensorData(self, variable, tensor_adaptor: Kratos.TensorAdaptors.DoubleTensorAdaptor, nodes_container: Kratos.NodesArray) -> Kratos.TensorAdaptors.DoubleTensorAdaptor:


Why do you need this function ? And what it does? I can't follow. Add please some doc

Added comments. Could you please check if it is descriptive enough?

__ExtractShapeUpdateFromDesignSurface() ???

May be we can add the check that it is used only in combination with SHAPE_VAR ? I guess it is not required for other variables ?

Can we avoid general names in the variables like tensor_adaptor and have more specific ones like, shape_update ?

sunethwarna · 2026-03-09T21:07:32Z

@Igarizza I addressed all of your comments. could you check?

Igarizza · 2026-03-10T10:59:58Z

            # model part
            return self.model_part.GetRootModelPart()

+    def __ExtractTensorData(self, variable, tensor_adaptor: Kratos.TensorAdaptors.DoubleTensorAdaptor, nodes_container: Kratos.NodesArray) -> Kratos.TensorAdaptors.DoubleTensorAdaptor:


__ExtractShapeUpdateFromDesignSurface() ???

May be we can add the check that it is used only in combination with SHAPE_VAR ? I guess it is not required for other variables ?

Igarizza · 2026-03-10T11:01:12Z

            # model part
            return self.model_part.GetRootModelPart()

+    def __ExtractTensorData(self, variable, tensor_adaptor: Kratos.TensorAdaptors.DoubleTensorAdaptor, nodes_container: Kratos.NodesArray) -> Kratos.TensorAdaptors.DoubleTensorAdaptor:


Can we avoid general names in the variables like tensor_adaptor and have more specific ones like, shape_update ?

Igarizza · 2026-03-10T11:31:16Z

      2,       2.6811e+03,                1.5885e-03
      3,       2.6677e+03,                1.5436e-03
-      4,       2.6191e+03,                1.5046e-03
+      4,       2.6841e+03,                1.5475e-03


Can we keep the test passing with original settings / values ?

Igarizza · 2026-03-10T11:39:29Z

+        condition_ta_p = Kratos.TensorAdaptors.VariableTensorAdaptor(self.model_part.Conditions, Kratos.PRESSURE)
+        condition_ta_p.CollectData()
+
+        nodal_ta_v = KratosOA.OptimizationUtils.MapContainerDataToNodalData(condition_ta_v, self.model_part.Nodes)


So this map is not a copy but rather a linking? So if later we change original var, nodal will change as well? Is map correct name in this case, because you not change map but you also sync. _Map&SyncConditionDatatoNodalData ?? Please comment as I am lost here =()

Nope, it will not change the model part values, so no automatic synching, but if you call nodal_ta_v.StoreData, then it will write the value to whatever the nodes [ manual synching by the request of the user]. So I would keep the name since there is no automatic synching.

Igarizza

@suneth Extremely good work! WoW! I have put few minor comments but in general excelent work!

…hape/vertex_morphing_shape_control.py Co-authored-by: IAntonau <igor.antonov92@gmail.com>

…_adaptor_update

sunethwarna · 2026-03-12T06:51:36Z

@Igarizza I addressed your comments and reverted the changes to the summary_ref.csv in this PR. This test is failing in the master as well. Unfortunately, it is skipped in the CI due to unavailability of scypy in the CI. We need to fix it in a seperate PR.

Igarizza

one more small thing and it is done=)

Igarizza · 2026-03-12T09:04:07Z


    def test_CombinedResponseCalculateValue3(self):
-        eval_resp = EvaluateResponseExpression("r1 + r2 + 4.0", self.optimization_problem)
+        eval_resp = EvaluateResponseExpression("(r1 + r2) * 1e+6 + 4.0", self.optimization_problem)


why do you cahnge this?

I was checking to fail this test before updating to TensorAdaptors, the problem was, it was not failing because, (r1 + r2) was super low, and the 4.0 was dominating the whole response... Thats why i made it a more sensible test.

Igarizza

I think, it is ready to go !!!

sunethwarna added 30 commits December 20, 2025 00:30

skip some tests if MeshMovingApplication is not found.

e0b72ec

add properties variable TA

b9f841f

expose to python

b6727b2

minor comment change in PropertiesVarTA

e38e3d5

add unit test to PropertiesVarTA

1c8e7ef

update mass resp utils to TA

fc6c076

update linear strain energy resp utils to TA

f238976

fix resp utils python exposure

262d261

add pGetContainer method for ContainerExps

39b448b

update python linear strain energy resp to TA

517a801

update mass response to TA

29cad0c

response utils minor update

c6bfa80

update sigmoidal utils to TA

a307c6e

update sigmoidal python exp to TA

e3314b2

update sigmoidal proj utils tests to TA

885f3bd

update opt_projection.py to TA

e46673a

Merge remote-tracking branch 'origin/master' into optapp_siapp_tensor…

dca09bc

…_adaptor_update

Merge remote-tracking branch 'origin/master' into optapp_siapp_tensor…

1a6cfc2

…_adaptor_update

change explicit damping

48582af

explicit filter utils update

9fe8fe9

integrated nearest entity update

6272421

undate nearest entity update

0e07e2a

Merge remote-tracking branch 'origin/master' into optapp_siapp_tensor…

88f320a

…_adaptor_update

bugfix

3dee71b

update explicit filter python to TA

4195300

update filter utils to TA

6f44f3f

update texplicit filter test to TA

48b2333

minor

34862e4

move TA to submodule

ad5339c

adding nodal neighour count TA

e4e9e89

Igarizza reviewed Mar 9, 2026

View reviewed changes

sunethwarna added 2 commits March 9, 2026 21:48

change to CalculateNodalDomainSizes

b2fdb62

more descriptive docs

a7d96bf

sunethwarna dismissed talhah-ansari’s stale review via a7d96bf March 9, 2026 20:48

added comments

346935a

sunethwarna requested a review from Igarizza March 9, 2026 21:07

Igarizza reviewed Mar 10, 2026

View reviewed changes

Comment thread ...tions/OptimizationApplication/python_scripts/controls/shape/vertex_morphing_shape_control.py Outdated

Igarizza reviewed Mar 10, 2026

View reviewed changes

sunethwarna and others added 7 commits March 10, 2026 18:25

Update applications/OptimizationApplication/python_scripts/controls/s…

877afec

…hape/vertex_morphing_shape_control.py Co-authored-by: IAntonau <igor.antonov92@gmail.com>

change to physical_variable_gradient_map

4f4402b

change to GetPhysicalKratosVariableMap

3df3f15

change to physical_variable_gradient_map

44569e7

change to "physical_variable_gradient_map"

e380912

Merge remote-tracking branch 'origin/master' into optapp_siapp_tensor…

7eba93b

…_adaptor_update

revert slsqp changes

be0a5a0

sunethwarna requested review from Igarizza and talhah-ansari March 11, 2026 17:37

sunethwarna and others added 2 commits March 11, 2026 18:41

change to __ExtractDesignSurfaceData

23ad5b1

bug fix.

e3c92fe

Igarizza reviewed Mar 12, 2026

View reviewed changes

sunethwarna enabled auto-merge March 12, 2026 09:13

sunethwarna requested a review from Igarizza March 12, 2026 09:13

Igarizza approved these changes Mar 12, 2026

View reviewed changes

sunethwarna merged commit f0cbb9e into master Mar 12, 2026
10 checks passed

sunethwarna deleted the optapp_siapp_tensor_adaptor_update branch March 12, 2026 09:15

Conversation

sunethwarna commented Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sunethwarna commented Mar 9, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Igarizza left a comment

Choose a reason for hiding this comment

Uh oh!

sunethwarna commented Mar 12, 2026

Uh oh!

Igarizza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Igarizza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants