Skip to content

Remove explicit checks against kp::Memory::type() #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axsaucedo merged 2 commits into from
Apr 13, 2026
Merged

Remove explicit checks against kp::Memory::type() #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b888179
algorithm: check DescriptorType when creating pool
ahem Apr 13, 2026
94a1449
Algorithm: check type before casting
ahem Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Algorithm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ Algorithm::createParameters()
KP_LOG_DEBUG("Kompute Algorithm createParameters started");

for (const std::shared_ptr<Memory>& mem : this->mMemObjects) {
if (mem->type() == Memory::Type::eImage) {
if (mem->getDescriptorType() == vk::DescriptorType::eStorageImage) {
numImages++;
} else {
numTensors++;
Expand Down
5 changes: 2 additions & 3 deletions src/OpAlgoDispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ OpAlgoDispatch::record(const vk::CommandBuffer& commandBuffer)

// For images the image layout needs to be set to eGeneral before using
// it for imageLoad/imageStore in a shader.
if (mem->type() == Memory::Type::eImage) {
std::shared_ptr<Image> image = std::static_pointer_cast<Image>(mem);

std::shared_ptr<Image> image = std::dynamic_pointer_cast<Image>(mem);
if (image) {
image->recordPrimaryImageBarrier(
commandBuffer,
vk::AccessFlagBits::eTransferWrite,
Expand Down
Loading