fix(ignore): Changes for new ZHC configureKey
#30402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Dec 30, 2025
Comment on lines
+102
to
+109
| const shouldReconfigure = | ||
| // Should always reconfigure when not configured before | ||
| device.zh.meta?.configured === undefined || | ||
| // Or should reconfigure when configureKey is not the default one (0) and differs from last configured configureKey | ||
| // In older z2m versions the stored configureKey (meta.configured) was the hash of the configure function. | ||
| // Since we don't want to reconfigure all devices, we don't re-configure when a device has the default configureKey of 0. | ||
| (configureKey !== 0 && device.zh.meta?.configured !== configureKey); | ||
| if (!shouldReconfigure) return; |
Collaborator
There was a problem hiding this comment.
This is not easy to read. Should bracket the if (follows most cases in Z2M/ZH) or at least add a new line to separate the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the automatic reconfigure based on the new
configureKeyintroduced in Koenkk/zigbee-herdsman-converters#11148. Note that the automatic re-configure was disabled before in #22088 but since it will now be stable (configureKeywill only change when strictly necessary) it can be enabled again.