Fix HA discovery conflict with color_mode and supported_color_modes#29528
Closed
CommitToday wants to merge 1 commit intoKoenkk:masterfrom
Closed
Conversation
Signed-off-by: SoulSniper1212 <warush23@gmail.com>
Koenkk
reviewed
Nov 9, 2025
| // Ensure deprecated color_mode field is not present when supported_color_modes is used | ||
| // This prevents Home Assistant from rejecting the discovery due to conflicting fields | ||
| if (payload.supported_color_modes && payload.color_mode === true) { | ||
| delete payload.color_mode; |
Owner
There was a problem hiding this comment.
color_mode has been removed a long time ago already, I also don't see any color_mode properties being added in this file. Could you provide the debug log when z2m discovers a device with color_mode?
See this on how to enable debug logging.
Contributor
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes an issue where Home Assistant would reject device discovery due to conflicting
color_modeandsupported_color_modesfields in the discovery payload. When both fields are present, Home Assistant treats it as an error. The fix ensures that the deprecatedcolor_modefield is removed whensupported_color_modesis present.Checklist
Proof that changes are correct
The fix is a simple conditional check that removes the
color_modefield whensupported_color_modesis present in the payload. This prevents the conflict that was causing Home Assistant to reject the discovery. The change is backwards compatible as it only removes the deprecated field in cases where the preferred field is present.