Add the ability to see which rule object has errored#335
Closed
hlascelles wants to merge 2 commits intoKnockout-Contrib:masterfrom
Closed
Add the ability to see which rule object has errored#335hlascelles wants to merge 2 commits intoKnockout-Contrib:masterfrom
hlascelles wants to merge 2 commits intoKnockout-Contrib:masterfrom
Conversation
Contributor
|
This looks pretty similar to #298 - what do you think? Would that implementation cover your requirement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to lookup the real error rule by exposing it. This can let a user perform different actions depending on other parameters of the error (eg you can make them do a popup if they serious/fatal as opposed to simpler notification if not fatal etc...)